Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default values for timeout and period in otel push exporter #168

Merged
merged 4 commits into from
Dec 15, 2023
Merged

add default values for timeout and period in otel push exporter #168

merged 4 commits into from
Dec 15, 2023

Conversation

mellowagain
Copy link
Member

@mellowagain mellowagain commented Dec 14, 2023 •
edited

Checklist

  • Changelog updated

@mellowagain mellowagain requested a review from a team December 14, 2023 15:18
gagbo
gagbo approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@gagbo gagbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice! I just have a minor nit but it’s definitely not a blocker

autometrics/src/otel_push_exporter.rs Show resolved Hide resolved
@mellowagain mellowagain merged commit 8aa7cf9 into main Dec 15, 2023
1 check passed
@mellowagain mellowagain deleted the default-env branch December 15, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagbo gagbo gagbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mellowagain @gagbo