Use OpenTelemetry histogram buckets #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Objective feature is currently broken only when using the
prometheusfeature flag and one of the followingObjectiveLatency:Ms150,Ms200,Ms350. This is because theprometheuscrate uses different buckets that do not include these values, and that crate has a different way of configuring the buckets. As a result, the SLO feature will not work when using one of those three latency targets.This PR switches from the previous buckets to using the default values from the OpenTelemetry specification.
While it is technically a breaking change to the autometrics API, we might want to release this as
v0.3.1and yankv0.3.0.