Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove opentelemetry as the default metrics library #97

Merged
merged 26 commits into from
May 24, 2023
Merged

Remove opentelemetry as the default metrics library #97

merged 26 commits into from
May 24, 2023

Conversation

emschwartz
Copy link
Contributor

Also make it so that enabling multiple metrics libraries will encode metrics multiple times. This is so that we don't need to make the features mutually exclusive.

Resolves #89, #95

emschwartz and others added 18 commits April 21, 2023 15:58
@emschwartz
[WIP]
b255f8c
@emschwartz
Update prometheus-client version
7cbe053
@emschwartz
Merge branch 'main' into prometheus-client-2
ff161ea
@emschwartz
Finish support for prometheus-client
9e402eb
@emschwartz
Fix doc links
f29aae1
@emschwartz
Ensure that prometheus-client is actually being used
11d052f
@emschwartz
Work on fixing tests, remove const_format dep
9817601
@emschwartz
Don't use regexes in tests (because different libraries order labels …
8635ad7 
…differently)
@emschwartz
Make once_cell a required dependency
8130657
@emschwartz
Rename concurrency tracker to gauge
49410dc
@emschwartz
Merge branch 'main' into prometheus-client-2
537553e
@emschwartz
Move PROMETHEUS_CLIENT_REGISTRY to integrations module
ecfe52f
@emschwartz
Run all the other tests first
e311510
@emschwartz
Run the tests in the same order
ad830c3
@emschwartz
The prometheus-exporter feature needs to depend on the prometheus fea…
4406f08 
…ture (for now)
@emschwartz
Rename export to just REGISTRY
43bea12
@emschwartz
Mention prometheus-client in readme and changelog
36f65e2
@emschwartz
Remove opentelemetry as the default metrics library
e3e2a9c
@emschwartz emschwartz mentioned this pull request May 23, 2023
Closed
mellowagain
mellowagain reviewed May 23, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
autometrics/README.md Show resolved Hide resolved
autometrics/src/prometheus_exporter.rs Show resolved Hide resolved
@emschwartz emschwartz mentioned this pull request May 23, 2023
Merged
Base automatically changed from prometheus-client-2 to main May 23, 2023 12:49
This was linked to issues May 23, 2023
Rethink how we handle the integrations with multiple metrics libraries #89
Closed
Refactor error handling #95
Closed
@emschwartz emschwartz merged commit 7396e13 into main May 24, 2023
1 check passed
@emschwartz emschwartz deleted the no-default-metrics-library branch May 24, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mellowagain mellowagain mellowagain approved these changes

@gagbo gagbo Awaiting requested review from gagbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor error handling Rethink how we handle the integrations with multiple metrics libraries
2 participants
@emschwartz @mellowagain