Revert "Fix long regresion"

This reverts commit 4fa4823.
automl · Jun 23, 2021 · 2ce1570 · 2ce1570
1 parent 4fa4823
commit 2ce1570
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/autoPyTorch/pipeline/components/training/trainer/__init__.py b/autoPyTorch/pipeline/components/training/trainer/__init__.py
@@ -249,9 +249,10 @@ def _fit(self, X: Dict[str, Any], y: Any = None, **kwargs: Any) -> 'TrainerChoic
         )
 
         # Support additional user metrics
-        additional_metrics = X['additional_metrics'] if 'additional_metrics' in X else []
+        additional_metrics = X['additional_metrics'] if 'additional_metrics' in X else None
         if 'optimize_metric' in X:
-            additional_metrics.append(X['optimize_metric'])
+            additional_metrics = additional_metrics.append(X['optimize_metric']) if additional_metrics is not None \
+                else [X['optimize_metric']]
         additional_losses = X['additional_losses'] if 'additional_losses' in X else None
         self.choice.prepare(
             model=X['network'],

diff --git a/cicd/test_preselected_configs.py b/cicd/test_preselected_configs.py
@@ -153,7 +153,7 @@ def test_can_properly_fit_a_config(openml_task_id, configuration, scorer, lower_
     train_data, target_data = fit_dictionary['backend'].load_datamanager().train_tensors
     predictions = pipeline.predict(train_data[val_indices])
     score = scorer(fit_dictionary['y_train'][val_indices], predictions)
-    assert score >= lower_bound_score
+    assert pytest.approx(score) >= lower_bound_score
 
     # Check that we reverted to the best score
     run_summary = pipeline.named_steps['trainer'].run_summary