Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Minor Fixes #306

Merged
merged 6 commits into from Nov 9, 2021
Merged

Conversation

ravinkohli
Copy link
Contributor

@ravinkohli ravinkohli commented Oct 26, 2021

Addresses issue #301 , and issue #283

@ravinkohli ravinkohli added this to In progress in release v0.1.0 via automation Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #306 (febe4b5) into development (a11caf4) will increase coverage by 0.01%.
The diff coverage is 87.09%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #306      +/-   ##
===============================================
+ Coverage        81.82%   81.84%   +0.01%     
===============================================
  Files              151      151              
  Lines             8646     8651       +5     
  Branches          1321     1322       +1     
===============================================
+ Hits              7075     7080       +5     
  Misses            1105     1105              
  Partials           466      466              
Impacted Files Coverage Δ
autoPyTorch/api/tabular_classification.py 87.50% <ø> (ø)
autoPyTorch/api/tabular_regression.py 96.87% <ø> (ø)
...nts/setup/network_backbone/ShapedResNetBackbone.py 100.00% <ø> (ø)
...e/components/setup/network_head/fully_connected.py 91.11% <69.23%> (-6.33%) ⬇️
autoPyTorch/api/base_task.py 84.63% <100.00%> (+0.16%) ⬆️
...ipeline/components/setup/network_backbone/utils.py 88.63% <100.00%> (+1.41%) ⬆️
...components/setup/network_initializer/XavierInit.py 100.00% <100.00%> (ø)
...omponents/training/data_loader/base_data_loader.py 90.54% <100.00%> (+0.39%) ⬆️
autoPyTorch/pipeline/tabular_classification.py 74.57% <100.00%> (-1.43%) ⬇️
...ocessing/feature_preprocessing/PowerTransformer.py 95.83% <0.00%> (-4.17%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11caf4...febe4b5. Read the comment docs.

@ravinkohli ravinkohli changed the title Minor Fixes [FIX] Minor Fixes Oct 27, 2021
Copy link
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I will add other comments soon.

Copy link
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

release v0.1.0 automation moved this from In progress to Review in progress Nov 5, 2021
ravinkohli and others added 3 commits November 8, 2021 13:12
Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
release v0.1.0 automation moved this from Review in progress to Reviewer approved Nov 9, 2021
@nabenabe0928 nabenabe0928 merged commit 4a29852 into automl:development Nov 9, 2021
release v0.1.0 automation moved this from Reviewer approved to Done Nov 9, 2021
github-actions bot pushed a commit that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants