New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] Dockerfile #314
[Add] Dockerfile #314
Conversation
Codecov Report
@@ Coverage Diff @@
## development #314 +/- ##
===============================================
- Coverage 82.09% 81.86% -0.24%
===============================================
Files 151 151
Lines 8651 8651
Branches 1322 1322
===============================================
- Hits 7102 7082 -20
- Misses 1084 1104 +20
Partials 465 465
Continue to review full report at Codecov.
|
@@ -0,0 +1,40 @@ | |||
FROM ubuntu:20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use any one of the docker images from here because some codes are assuming that we can use torch on CUDA. FYI, basically people use xxx-devel-xxx
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to use this ubuntu container for the dockerfile that we upload to the docker hub. I think the most general use case is to use CPU. If someone would like to use it with CUDA, it is quite easy for them to edit this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, i don't think pynisher works properly when we use CUDA, but have you ever tried any runs on CUDA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually thats a good point. I'll create an issue and a subsequent PR where we can use docker to run all our tests on cuda. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great:)
This resolves issue #231. But it is an incomplete implementation. The rest has been raised as another issue #315.