Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Additional metrics during training #316

Merged
merged 4 commits into from Nov 12, 2021

Conversation

ravinkohli
Copy link
Contributor

This PR fixes #101

@ravinkohli ravinkohli added the bug Something isn't working label Nov 11, 2021
@ravinkohli ravinkohli added this to In progress in release v0.1.0 via automation Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #316 (b990f8a) into development (e493d99) will decrease coverage by 0.23%.
The diff coverage is 84.21%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #316      +/-   ##
===============================================
- Coverage        82.01%   81.78%   -0.24%     
===============================================
  Files              151      152       +1     
  Lines             8652     8669      +17     
  Branches          1322     1325       +3     
===============================================
- Hits              7096     7090       -6     
- Misses            1088     1113      +25     
+ Partials           468      466       -2     
Impacted Files Coverage Δ
autoPyTorch/evaluation/abstract_evaluator.py 76.00% <84.21%> (+1.21%) ⬆️
...eline/components/setup/optimizer/base_optimizer.py 71.42% <0.00%> (-19.05%) ⬇️
...abular_preprocessing/base_tabular_preprocessing.py 66.66% <0.00%> (-13.34%) ⬇️
...ne/components/setup/lr_scheduler/base_scheduler.py 86.20% <0.00%> (-6.90%) ⬇️
...up/network_initializer/base_network_initializer.py 93.54% <0.00%> (-6.46%) ⬇️
.../pipeline/components/setup/network/base_network.py 88.05% <0.00%> (-5.98%) ⬇️
...nts/setup/early_preprocessor/EarlyPreprocessing.py 85.71% <0.00%> (-5.72%) ⬇️
...ine/components/training/trainer/StandardTrainer.py 96.29% <0.00%> (-3.71%) ⬇️
...omponents/training/data_loader/base_data_loader.py 90.54% <0.00%> (-2.71%) ⬇️
autoPyTorch/pipeline/components/base_component.py 80.95% <0.00%> (-1.91%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e493d99...b990f8a. Read the comment docs.

@ravinkohli ravinkohli linked an issue Nov 11, 2021 that may be closed by this pull request
Copy link
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.
I added two minor suggestions.

autoPyTorch/evaluation/abstract_evaluator.py Outdated Show resolved Hide resolved
self.fit_dictionary['runtime'] = self.budget
self.fit_dictionary.pop('epochs', None)
else:
raise ValueError(f"Unsupported budget type {self.budget_type} provided")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ValueError(f"Unsupported budget type {self.budget_type} provided")
raise ValueError(f"budget type must be `epochs` or `runtime`, but got {self.budget_type}")

release v0.1.0 automation moved this from In progress to Review in progress Nov 12, 2021
Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
@nabenabe0928 nabenabe0928 merged commit 9559849 into automl:development Nov 12, 2021
release v0.1.0 automation moved this from Review in progress to Done Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Additional metrics in the trainer
2 participants