Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] remove .pth for early stopping #321

Merged
merged 4 commits into from Nov 15, 2021

Conversation

ravinkohli
Copy link
Contributor

Fixes #110

@ravinkohli ravinkohli linked an issue Nov 11, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #321 (cd9ee6b) into development (e493d99) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #321      +/-   ##
===============================================
- Coverage        82.01%   81.73%   -0.28%     
===============================================
  Files              151      152       +1     
  Lines             8652     8674      +22     
  Branches          1322     1325       +3     
===============================================
- Hits              7096     7090       -6     
- Misses            1088     1115      +27     
- Partials           468      469       +1     
Impacted Files Coverage Δ
...h/pipeline/components/training/trainer/__init__.py 72.91% <100.00%> (+0.72%) ⬆️
...eline/components/setup/optimizer/base_optimizer.py 71.42% <0.00%> (-19.05%) ⬇️
...abular_preprocessing/base_tabular_preprocessing.py 66.66% <0.00%> (-13.34%) ⬇️
...ne/components/setup/lr_scheduler/base_scheduler.py 86.20% <0.00%> (-6.90%) ⬇️
...up/network_initializer/base_network_initializer.py 93.54% <0.00%> (-6.46%) ⬇️
.../pipeline/components/setup/network/base_network.py 88.05% <0.00%> (-5.98%) ⬇️
...nts/setup/early_preprocessor/EarlyPreprocessing.py 85.71% <0.00%> (-5.72%) ⬇️
...ine/components/training/trainer/StandardTrainer.py 96.29% <0.00%> (-3.71%) ⬇️
...pipeline/components/setup/lr_scheduler/CyclicLR.py 94.28% <0.00%> (-2.86%) ⬇️
...omponents/training/data_loader/base_data_loader.py 90.54% <0.00%> (-2.71%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e493d99...cd9ee6b. Read the comment docs.

@ravinkohli ravinkohli added the bug Something isn't working label Nov 15, 2021
@nabenabe0928 nabenabe0928 merged commit 28e1d47 into automl:development Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the temporal .pth files left by early stopping
2 participants