Rework Envs #89
Merged
Rework Envs #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
benjamc
commented
May 25, 2023
•
benjamc
commented
- New CARL env
- Port classic control
- Port brax
- Port dmc
- Port box2d
- Port mario
- Port RNA
- Add unit tests for new CARL env
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #89 +/- ##
===============================================
- Coverage 22.48% 19.05% -3.43%
===============================================
Files 76 78 +2
Lines 4479 4030 -449
Branches 565 555 -10
===============================================
- Hits 1007 768 -239
+ Misses 3423 3224 -199
+ Partials 49 38 -11 |
benjamc
commented
Jun 9, 2023
carl/context/context_space.py
Outdated
| """ | ||
| return [ | ||
| UniformFloatHyperparameter( | ||
| "gravity", lower=0.1, upper=np.inf, default_value=9.8 |
There was a problem hiding this comment.
Ask Eddie about np.inf as bounds in uniform
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
TheEimer
reviewed
Jun 9, 2023
benjamc
commented
Jul 3, 2023
|
|
||
| return spaces.Box(low=low, high=high, dtype=np.float32) | ||
|
|
||
| def sample_contexts( |
There was a problem hiding this comment.
- Remove sample contexts
|
I updated Mario and RNA but couldn't test either:
So I'd add:
|
This was referenced Jul 13, 2023
* Extend gitignore * Add DMC Finger (current status) * current status * Current status * Current status * Current status * Format * Format + pre-commit * Remove test notebook * Add method to check if it is okay to set context feature Because we might have incomplete contexts * Add more tests * Format * Format * Merge main * gravity bounds * More tests * Correct gravity bounds Co-authored-by: Carolin Benjamins <benjamins@tnt.uni-hannover.de> Co-authored-by: sebidoe <45859263+sebidoe@users.noreply.github.com>
* Fix format, fix tests * Fix format * Increase coverage * Remove test code * Add more tests Co-authored-by: Carolin Benjamins <benjamins@tnt.uni-hannover.de>
* update install_requires * § * fix imports: gym → gymnasium * fix step function * fix step * gym->gymnasium * § * fix * fix * fix * fix * fix * fix render * . * fix all step returns * Delete build/lib/carl directory * Delete myenv directory * Update README.md Fix documentation link. * make pre-commit and format * rename every occurrence of trunched to truncated * @Arman717 * change trunched to truncated * Fix gymnasium version with box2d --------- Co-authored-by: C. Benjamins <75323339+benjamc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.