Fixed a minor bug in the get_pandas_dataframe function of Result #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class
The loss_fn lambda was not being used and as a result, only the losses and not any info can be retrieved. For e.g by saying loss_fn = lambda r: {"val_NLL": r.loss, "val_err": r.info['valid err']}.
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 65.16% 64.78% -0.38%
==========================================
Files 28 28
Lines 1846 1846
==========================================
- Hits 1203 1196 -7
- Misses 643 650 +7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loss_fnlambda was not being used and as a result, only the losses and not any info can be retrieved, for e.g by sayingloss_fn = lambda r: {"val_NLL": r.loss, "val_err": r.info['valid err']}.This PR does not change the default behaviour.