Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug?] RunHistory2EPM4EIPS is incrementing time twice before taking logarithm #833

Closed
mhlr opened this issue Apr 18, 2022 · 1 comment · Fixed by #842
Closed

[Bug?] RunHistory2EPM4EIPS is incrementing time twice before taking logarithm #833

mhlr opened this issue Apr 18, 2022 · 1 comment · Fixed by #842

Comments

@mhlr
Copy link

mhlr commented Apr 18, 2022

The time is being incremented in both _build_matrix:

SMAC3/smac/runhistory/runhistory2epm.py

Line 784 in 863e429

values[:, 1] = np.log(1 + values[:, 1])

and transform_response_values

SMAC3/smac/runhistory/runhistory2epm.py

Line 763 in 863e429

y[row, 1] = 1 + run.time

@mhlr mhlr changed the title RunHistory2EPM4EIPS is incrementing time twice befor logarithm RunHistory2EPM4EIPS is incrementing time twice before taking logarithm Apr 18, 2022
@mhlr mhlr changed the title RunHistory2EPM4EIPS is incrementing time twice before taking logarithm [Bug?] RunHistory2EPM4EIPS is incrementing time twice before taking logarithm Apr 18, 2022
@dengdifan
Copy link
Contributor

Hi,
thanks for pointing that out! This is indeed a bug, we will fix that in the next version

This was referenced May 12, 2022
Merged
Merged
@renesass renesass mentioned this issue May 19, 2022
Merged
renesass added a commit that referenced this issue May 19, 2022
@renesass @DE0CH
Version 1.3.3
fc2fc14 
* Hotfix: Since multi-objective implementation depends on normalized costs, it now is ensured that the
cached costs are updated everytime a new entry is added.
* Removed mac-specific files.
* Added entry point for cli.
* Added `ConfigSpace` to third known parties s.t. sorting should be the same across different
operating systems.
* Fixed bugs in makefile in which tools were specified incorrectly.
* Executed isort/black on examples and tests.
* Updated README.
* Fixed a problem, which incremented time twice before taking log (#833).
* New wrapper for multi-objective models (base_uncorrelated_mo_model). Makes it easier for
developing new multi-objective models.
* Raise error if acquisition function is incompatible with the epm models.
* Restricting pynisher.

Co-authored-by: Difan Deng <deng@dengster.tnt.uni-hannover.de>
Co-authored-by: Deyao Chen <chendeyao000@gmail.com>
Co-authored-by: BastianZim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SMAC board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rh2eips fix automl/SMAC3
4 participants
@mhlr @renesass @eddiebergman @dengdifan