Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled pipeline fit #1096

Merged
merged 5 commits into from Apr 13, 2021
Merged

Enabled pipeline fit #1096

merged 5 commits into from Apr 13, 2021

Conversation

franchuterivera
Copy link
Contributor

addresses #886

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #1096 (426c2e1) into development (8c7154f) will increase coverage by 0.01%.
The diff coverage is 86.84%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1096      +/-   ##
===============================================
+ Coverage        85.46%   85.48%   +0.01%     
===============================================
  Files              137      137              
  Lines            10557    10618      +61     
===============================================
+ Hits              9023     9077      +54     
- Misses            1534     1541       +7     
Impacted Files Coverage Δ
autosklearn/util/pipeline.py 83.58% <72.72%> (+0.76%) ⬆️
autosklearn/automl.py 84.85% <87.34%> (+0.08%) ⬆️
autosklearn/estimators.py 93.47% <90.90%> (+0.40%) ⬆️
autosklearn/smbo.py 84.83% <100.00%> (+0.99%) ⬆️
...ature_preprocessing/select_rates_classification.py 78.87% <0.00%> (-8.46%) ⬇️
autosklearn/evaluation/__init__.py 79.91% <0.00%> (-0.86%) ⬇️
autosklearn/evaluation/train_evaluator.py 73.46% <0.00%> (ø)
autosklearn/util/backend.py 76.51% <0.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7154f...426c2e1. Read the comment docs.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, just a bunch of comments on the API. I think we can discuss all of this offline later.

examples/40_advanced/example_single_configuration.py Outdated Show resolved Hide resolved
examples/40_advanced/example_single_configuration.py Outdated Show resolved Hide resolved
autosklearn/estimators.py Show resolved Hide resolved
autosklearn/estimators.py Outdated Show resolved Hide resolved
autosklearn/estimators.py Outdated Show resolved Hide resolved
autosklearn/automl.py Outdated Show resolved Hide resolved
autosklearn/automl.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, this feature is way more complicated than I anticipated. Also, do you think #709 can be solved as a side effect?

autosklearn/estimators.py Outdated Show resolved Hide resolved
autosklearn/estimators.py Outdated Show resolved Hide resolved
autosklearn/estimators.py Outdated Show resolved Hide resolved
scripts/run_auto-sklearn_for_metadata_generation.py Outdated Show resolved Hide resolved
scripts/run_auto-sklearn_for_metadata_generation.py Outdated Show resolved Hide resolved
test/test_automl/test_estimators.py Outdated Show resolved Hide resolved
test/test_automl/test_estimators.py Outdated Show resolved Hide resolved
test/test_automl/test_estimators.py Show resolved Hide resolved
test/test_automl/test_estimators.py Outdated Show resolved Hide resolved
autosklearn/automl.py Outdated Show resolved Hide resolved
@mfeurer
Copy link
Contributor

mfeurer commented Apr 1, 2021

Looks good, I only have four (hopefully small) comment left.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I just tried this locally to debug a weird pipeline and have a few more suggestions. But this features will be really helpful (and already was, uncovered a pretty nasty bug using it)!

autosklearn/automl.py Outdated Show resolved Hide resolved
autosklearn/automl.py Outdated Show resolved Hide resolved
autosklearn/smbo.py Outdated Show resolved Hide resolved
autosklearn/smbo.py Outdated Show resolved Hide resolved
autosklearn/automl.py Outdated Show resolved Hide resolved
autosklearn/automl.py Show resolved Hide resolved
autosklearn/automl.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants