Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix variable name #1200

Merged
merged 2 commits into from Aug 4, 2021
Merged

Conversation

hnishi
Copy link
Contributor

@hnishi hnishi commented Jul 31, 2021

This is a small fix.

Use automl variable that is function's argument instead of cls variable that is defined outside the function.

@hnishi hnishi changed the title Fix variable name Doc: Fix variable name Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #1200 (ae84108) into master (3d53cd9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
- Coverage   88.16%   88.14%   -0.02%     
==========================================
  Files         138      138              
  Lines       10866    10866              
==========================================
- Hits         9580     9578       -2     
- Misses       1286     1288       +2     
Impacted Files Coverage Δ
...eline/components/feature_preprocessing/fast_ica.py 91.30% <0.00%> (-6.53%) ⬇️
...ine/components/feature_preprocessing/kernel_pca.py 94.73% <0.00%> (-1.76%) ⬇️
...ature_preprocessing/select_rates_classification.py 85.91% <0.00%> (-1.41%) ⬇️
...learn/pipeline/components/regression/libsvm_svr.py 90.24% <0.00%> (-1.22%) ⬇️
...mponents/feature_preprocessing/nystroem_sampler.py 91.17% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d53cd9...ae84108. Read the comment docs.

Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hnishi, thanks for spotting this and providing a PR fix it all looks good and is much appreciated :)

As it's currently not broken in master so I've swapped this to the development branch for now. It should be in the master version in our next release. If you wish to contribute anything else in the future we recommend doing so from the development branch!

Happy Wednesday,
Eddie

@eddiebergman eddiebergman changed the base branch from master to development August 4, 2021 10:02
@eddiebergman eddiebergman merged commit d761cb3 into automl:development Aug 4, 2021
github-actions bot pushed a commit that referenced this pull request Aug 4, 2021
@hnishi hnishi deleted the fix_variable_name branch August 4, 2021 14:38
eddiebergman pushed a commit that referenced this pull request Aug 18, 2021
The function `def get_runhistory_models_performance(automl):` didn't use the parameter `automl` and instead used the global variable `cls`. This PR fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants