Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade pandas>=1.0 #948

Merged
merged 2 commits into from Oct 28, 2020
Merged

Conversation

lilleswing
Copy link
Contributor

pandas 1.0 was released in January 2020 and removed many deprecated commands. Hopefully the travis tests can show where we are using deprecated API and we can swap them out one at a time.

@lilleswing
Copy link
Contributor Author

This seems to be passing the non 3.5 tests which are being dropped in #947. Are there known issues with removing back-words capable pandas that need to be dealt with @mfeurer ?

@mfeurer
Copy link
Contributor

mfeurer commented Sep 16, 2020

Thanks @lilleswing for picking this up.

Your change appears to work well on the master branch, however, we made some changes to pandas handling in the development branch so I'd like to see how this does there.

As for why we haven't updated yet - we're building on openml-python for generating the meta-data, and the latest release there doesn't know about pandas 1.0 yet. But apparently this isn't an issue in the unit tests which is great.

@lilleswing lilleswing changed the base branch from master to development September 16, 2020 14:03
@mfeurer
Copy link
Contributor

mfeurer commented Oct 28, 2020

As for why we haven't updated yet - we're building on openml-python for generating the meta-data, and the latest release there doesn't know about pandas 1.0 yet. But apparently this isn't an issue in the unit tests which is great.

We have released a new version of the OpenML connector which works with pandas>=1.0, so this can safely be merged. Thanks a lot for your contribution @lilleswing

@mfeurer mfeurer merged commit c363cd6 into automl:development Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants