feat(cli): builds can now be done through docker #153
Conversation
…e no dependency issues
ghost
assigned 
| @@ -19,6 +19,7 @@ public class ProcessInvoker : IProcessInvoker | |||
| { | |||
| #region Fields | |||
| private readonly ILogger logger; | |||
| private readonly bool isRealtime = false; | |||
There was a problem hiding this comment.
Is this necessary? Does it negatively impact us to have logging here all the time? If the logs are too verbose; perhaps we make the verbosity configurable, but I'm not a fan of disjointed flags like this. What does it mean to be realtime? how does the behavior change of this... thing?
:)
There was a problem hiding this comment.
Good point. originally everything was added to a queue and then output after execution. This made no sense when running MSBuild since some projects can take a while to run and giving feedback is important.
I have seen large output of text create a slowdown in execution before but for our use-case i doubt it would be an issue.
I like the idea of adding verbosity into the mix, but would need to work out some details
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Target Name="DockerBuild" Condition=" $(DockerBuild) "> | |||
| <Exec Command="docker build --label %(DockerMetadata.Label) --tag %(DockerMetadata.VersionLabel) ." | |||
| <Exec Command="docker build --label %(DockerMetadata.Label) --tag %(DockerMetadata.VersionLabel) -f %(DockerMetadata.Identity) ." | |||
docker run -v ${pwd}:/target condo:latest