Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): update images to dotnet core 2.1 #206

Merged
merged 1 commit into from
Jun 7, 2018
Merged

fix(docker): update images to dotnet core 2.1 #206

merged 1 commit into from
Jun 7, 2018

Conversation

sjk07
Copy link
Member

@sjk07 sjk07 commented Jun 7, 2018 •
edited

  • update all images to dotnet core 2.1
  • pushed images to repository
  • fixed docker-metadata, will not get correct project name
  • allow docker tags to be created with $DockerOrganization even if $DockerPush is false
  • Add simple docs for env vars and docker in docker

closes #203

@ghost ghost assigned sjk07 Jun 7, 2018
@ghost ghost added the review label Jun 7, 2018
@sjk07 sjk07 merged commit 8094ceb into develop Jun 7, 2018
@ghost ghost removed the review label Jun 7, 2018
@sjk07 sjk07 deleted the docker/net-core2.1 branch June 7, 2018 18:57
This was referenced Jun 7, 2018
Open
Closed
sjk07 pushed a commit that referenced this pull request Jun 7, 2018
fix: regression in #206
fedf898
dmccaffery pushed a commit that referenced this pull request Jun 7, 2018
@sjk07 @dmccaffery
fix: regression in #206 (#208)
4dacb83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmccaffery dmccaffery dmccaffery approved these changes

Assignees

@sjk07 sjk07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(docker): Push dotnet 2.1 version of docker containers to dockerhub
2 participants
@sjk07 @dmccaffery