Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove commented path from the the $SHELL line reported at the end of prompt install #64

Closed
dmccaffery opened this issue Nov 20, 2020 · 2 comments · Fixed by #70
Closed
Assignees

Comments

@dmccaffery
Copy link
Member

image

If someone copies the entire command (including the comment containing the expected shell path), then an error will be reported.

We should remove (or move) the path as its unclear whether or not that should be copied.

@dmccaffery
Copy link
Member Author

echo " PLEASE RUN: exec -l \$SHELL # ($SHELL)"

@patrickserrano
Copy link
Contributor

Oh man I've seen people do this. Would it make sense to do something like:

echo "${CLR_BRIGHT_BLUE}"
echo "\$SHELL set to: $SHELL"
echo "${CLR_CLEAR}"
echo "${CLR_SUCCESS}"
echo "##############################################################################"
echo "##############################################################################"
echo "     PLEASE RUN: exec -l \$SHELL"
echo "##############################################################################"
echo "##############################################################################"
echo "${CLR_CLEAR}"

That way it's clear what the value of $SHELL is and it's out of the comment asking the user to take action.

I don't know that it makes sense to remove printing $SHELL because depending on how prompt was installed a user could end up changing their default shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants