style: cleanup command usage #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: The `docker-credential-gcr` helper should not be used on workstations where gcloud is installed. Users should use the following instead: ```sh gcloud auth configure-docker ```
NOTE: This will only work on more recent distributions for WSL but will dramatically improve performance of the prompt in git paths that are mounted from the windows file system. The use of the windows version of git only applies to windows mount path. The local (linux) version of git is used otherwise.
|
@dmccaffery tests for macOS are failing and it looks like there's no output? |
| export GPG_TTY | ||
| export SSH_AUTH_SOCK | ||
|
|
||
| # launch gpg-agent using the expected tty and sock |
There was a problem hiding this comment.
@dmccaffery looks like the test for this script is failing on Debian 9.
There was a problem hiding this comment.
@dmccaffery I ran the test on a new Debian instance and was able to execute the tests without issue. Do you want to chalk this up to CI flakiness?
Yeah; they never queued. Pretty sure it was just a fluke, but the other failed builds kept me from requeueing for now. |
sjk07
approved these changes
Feb 2, 2021
patrickserrano
approved these changes
Feb 2, 2021
|
🎉 This PR is included in version 8.3.0-next.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.