Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockerize condo #83

Closed
14 tasks done
dmccaffery opened this issue May 30, 2017 · 5 comments
Closed
14 tasks done

feat: dockerize condo #83

dmccaffery opened this issue May 30, 2017 · 5 comments
Assignees
Projects
Milestone

Comments

@dmccaffery
Copy link
Member

dmccaffery commented May 30, 2017

add support for executing condo as a docker container:

  • derive a docker container from microsoft/dotnet/latest (Linux)
  • derive a docker container from microsoft/dotnet/nanoserver (Windows)
  • map /src within the container to $pwd
  • copy precompiled copy of condo tasks to /condo within the containers
  • create simplified condo init script for use within the container
    • use well-known paths /condo and /src
    • do NOT update condo within the container
    • remove support for sourcing condo from different paths, uris, and branches
    • do NOT install dotnet or the sdk within the container (will already exist)
    • exec msbuild against /src/condo.build with the condo targets path set appropriately
  • update default condo.sh and condo.ps1 to execute condo within a container when available
    • detect docker-cli
    • pull and run latest condo container with mapped /src path
    • pass cli arguments through to the condo init script within the container
@dmccaffery dmccaffery added this to the 3.0.0 milestone May 30, 2017
@dmccaffery dmccaffery self-assigned this May 30, 2017
@dmccaffery dmccaffery added this to New in condo May 30, 2017
@sjk07
Copy link
Member

sjk07 commented May 30, 2017

How involved is this? Would love to give it a shot

@dmccaffery
Copy link
Member Author

I will update with tasks in this feature later tonight :)

@dmccaffery
Copy link
Member Author

@sjk07 sorry for the delay -- I've added what I believe to be the required tasks to getting this working effectively. Feel free to put in multiple PR's as you work through this if you still want to take it up -- no need for an all or nothing approach.

@sjk07
Copy link
Member

sjk07 commented Jul 22, 2017

After chatting with @dmccaffery we have decided to go with the following:

  • Create a docker image for each version of .net core (*unix and winodws)
  • Pulled container will be specified via global.json. Default will be latest. Override specified by CLI flag

@sjk07
Copy link
Member

sjk07 commented Dec 11, 2017

#153 closes this

@sjk07 sjk07 closed this as completed Dec 11, 2017
@ghost ghost removed the in progress label Dec 11, 2017
@sjk07 sjk07 moved this from New to Done in condo Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
condo
Done
Development

No branches or pull requests

2 participants