Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Mute/unmute people not in the game the same as dead people #253

Closed
Saars1337 opened this issue Nov 12, 2020 · 12 comments
Closed

Comments

@Saars1337
Copy link

It's nice to have additional people sitting in the Discord channel so they can wait to join the game.

We find that they accidentally give away information when the discussion phase comes up without realizing

@psykzz
Copy link

psykzz commented Nov 13, 2020

Having this as a setting default to off.

@wicusbester
Copy link

I think it's a great idea as people spoiling the game regularly happens to me. Sometimes they pick something up that the players don't like when someone is very quiet

@varedz
Copy link

varedz commented Nov 24, 2020

Impossible due to rate limit issues. Would simply just be too many requests.

@RdJNL
Copy link

RdJNL commented Dec 26, 2020

Well, this could be a feature for people self hosting the bot. I don't think rate limits are an issue in that case. Of course this depends on the amount of games the self hosted bot runs at the same time. But my self hosted bot runs only one game at a time, so it should be fine.

@Erfa
Copy link

Erfa commented Dec 27, 2020

This is definitely possible, SilenceAmongUs does it, although they mute spectators both during tasks and meetings. The only time spectators are allowed to speak is during the lobby phase when a game isn't ongoing. I'd really prefer if spectators followed the same rules as dead players, or at least be possible to configure.

@RdJNL
Copy link

RdJNL commented Dec 27, 2020

It should be possible to configure it in the same way as you can alive and dead players.

@denverquane
Copy link
Collaborator

Well, this could be a feature for people self hosting the bot. I don't think rate limits are an issue in that case.

Unfortunately not true. It's less of an issue, but Discord still very much limits inbound guild member PATCH requests. Most of the time, this is 10 mute/deafens in 10 seconds, but sometimes it dips to 5/5. Adding another worker bot is a decent mitigation, but very much not ideal for the problem.

SilenceAmongUs does it

Sure, but as Tanner and I have discussed at length, it still introduces rate limiting and slowdowns, particularly for full games.
discord/discord-api-docs#2204

I'm still interested in this feature to be sure, but it's not a trivial feature to implement, for several reasons

@varedz
Copy link

varedz commented Dec 27, 2020

Beat me to it you speedy man.

@RdJNL
Copy link

RdJNL commented Dec 27, 2020

Well, that sucks. I appreciate the attempt to get discord to change something to make this possible.

@denverquane
Copy link
Collaborator

This feature will be added very shortly, just it will just be Self-hosted/Premium only, due to how spectators impact the overall load on the bot and rate-limits :) (and it will default to "off")

I have the core functionality working on a side branch, but I might tweak if spectators are displayed in the status messages or not. It's a bit more work to determine which players are spectators, as opposed to doing all the muting behind the scenes without any visual display, but IMO the visual component would be nice

@RdJNL
Copy link

RdJNL commented Jan 4, 2021

Awesome 👍

@denverquane
Copy link
Collaborator

Added in 6.8.0, will continue to work the visual component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants