-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config, add missing symbol NTN-ATN to client and the simulator. #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jason-Zhangxin-Chen I have found an error in file data_source_simulator/README.md
The old URI for the simulator feed is given in section:
Query symbol prices
Same API spec as Binance API spec for the handler of "/api/v3/ticker/price", the query string contains parameter symbols
and its value which is a JSON list of string of symbol name.
curl -X 'GET' 'http://127.0.0.1:50991/api/v3/ticker/price?symbols=%5B%22NTN-USD%22%2C%22ATN-USD%22%5D' -H 'accept: application/json'
The new URI is https://simfeed.bakerloo.autonity.org/api/v3/ticker/price
i.e. the curl should be:
curl -X 'GET' 'https://simfeed.bakerloo.autonity.org/api/v3/ticker/price?symbols=%5B%22NTN-USD%22%2C%22ATN-USD%22%5D' -H 'accept: application/json'
resolved in 861fc91 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Add the missing symbol as one of the default symbols in oracle client, and add it in the data simulator as well.