-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCGC_CAX plugin #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default configs look good to me :+1
Thanks @Jason-Zhangxin-Chen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi lgtm. I've left some suggestions on README edits.
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found one more typo!
Co-authored-by: Jay <jc@clearmatics.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR includes the following changes:
@raj-shekhar1 @cmjc , please double check if the default configuration of CAX plugin is correct: