Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCGC_CAX plugin #2

Merged
merged 26 commits into from
Nov 16, 2023
Merged

PCGC_CAX plugin #2

merged 26 commits into from
Nov 16, 2023

Conversation

Jason-Zhangxin-Chen
Copy link
Collaborator

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen commented Nov 2, 2023

This PR includes the following changes:

  • Refactoring to remove duplicate code in the resolution of configuration in plugins.
  • Addition of a new PCGC_CAX plugin for autonity round4 games, along with its corresponding tests.
  • Enhancement of the plugin configuration file by providing examples and explanations for all possible configurations.

@raj-shekhar1 @cmjc , please double check if the default configuration of CAX plugin is correct:

var defaultConfig = types.PluginConfig{
	Key:                "",
	Scheme:             "https",
	Endpoint:           "cax.devnet.clearmatics.network", // todo: replace it with cax.piccadilly.autonity.org for piccadilly network.
	Timeout:            10,                               //10s
	DataUpdateInterval: 3600,                             //3600s, todo: if there is a rate limit for the CAX service, we'd need to set it properly.
}

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen changed the title [WIP] PCGC_CAX plugin PCGC_CAX plugin Nov 6, 2023
Copy link
Contributor

@raj-shekhar1 raj-shekhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default configs look good to me :+1
Thanks @Jason-Zhangxin-Chen

Copy link
Collaborator

@cmjc cmjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi lgtm. I've left some suggestions on README edits.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config/plugins-conf.yml Outdated Show resolved Hide resolved
config/plugins-conf.yml Outdated Show resolved Hide resolved
config/plugins-conf.yml Outdated Show resolved Hide resolved
config/plugins-conf.yml Outdated Show resolved Hide resolved
config/plugins-conf.yml Outdated Show resolved Hide resolved
Jason-Zhangxin-Chen and others added 15 commits November 7, 2023 11:25
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Co-authored-by: Jay <jc@clearmatics.com>
Copy link
Collaborator

@cmjc cmjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found one more typo!

config/plugins-conf.yml Outdated Show resolved Hide resolved
Co-authored-by: Jay <jc@clearmatics.com>
Copy link
Collaborator

@cmjc cmjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@lorenzo-dev1 lorenzo-dev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen merged commit 56856e1 into master Nov 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants