Update default config for plugins. #6
Conversation
Jason-Zhangxin-Chen
requested review from
lorenzo-dev1,
cmjc and
raj-shekhar1
plugins/pcgc_cax/pcgc_cax.go
Outdated
| Endpoint: "cax.devnet.clearmatics.network", // todo: replace it with cax.piccadilly.autonity.org for piccadilly network. | ||
| Timeout: 10, //10s | ||
| DataUpdateInterval: 3600, //3600s, todo: if there is a rate limit for the CAX service, we'd need to set it properly. | ||
| Endpoint: "cax.devnet.clearmatics.network", |
There was a problem hiding this comment.
| Endpoint: "cax.devnet.clearmatics.network", | |
| Endpoint: "cax.piccadilly.autonity.org", |
@Jason-Zhangxin-Chen edit to change to the root exchange URI for Piccadilly.
(Note the URI for calls to the SIM API is: https://cax.piccadilly.autonity.org/api/
I assume you want the root URI not the API URI - unless you are calling an API function?
FYSA @aiman
There was a problem hiding this comment.
@Jason-Zhangxin-Chen edit to change to the root exchange URI for Piccadilly.
(Note the URI for calls to the SIM API is: https://cax.piccadilly.autonity.org/api/
I assume you want the root URI not the API URI - unless you are calling an API function?
FYSA @aiman
I got some timeout error from switching to this host cax.piccadilly.autonity.org for the data from CAX service of piccadilly, please confirm that service is deployed, but anyway it is configurable. Please confirm such change, and I will do some testing on the new service endpoint before we go ahead.
Moreover that, why would we add a prefix /api for the service routing in piccadilly? I would ask to keep the URLs to be unified for different network environments, because it will be easier to maintain a single version of CAX plugin for devnet, piccadilly and bakerloo. For example, current CAX plugin of devnet fetch the data points in a full router like this: https://cax.devnet.clearmatics.network/orderbooks/ATN-USD/quote
if we can keep the same routing pattern like below for piccadilly, it would be nice.
https://cax.piccadilly.autonity.org/orderbooks/ATN-USD/quote
There was a problem hiding this comment.
The CAX for Piccadilly is not deployed yet, the deployment is in-progress.
There was a problem hiding this comment.
@cmjc @raj-shekhar1, to support CAX service of both dev-net and piccadilly, I introduced a build flag in bafb105, @raj-shekhar1 you can build oracle server and the plugins for dev-net by make autoracle-dev while make autoracle will build things for piccadilly. This will make things be simple now.
Yes, that is interesting. |
To close #5 , we update the default data update interval to 30s to get more realtime data from source, and we also hide the data service keys used in our test from the public plugin-conf.yml to prevent people from using it by mistake.
@lorenzo-dev1 please review it, I will release this soon.
@raj-shekhar1, please review it, you will need to upgrade the oracle server from v0.1.3 to v0.1.4, or you can only need to upgrade the plugins of v0.1.3 with the plugins of v0.1.4 for the test network, piccadily network, and bakerloo as well.