Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement, deprecate the symbols flag & make binaries for Bakerloo testnet. #8

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

Jason-Zhangxin-Chen
Copy link
Collaborator

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen commented Dec 5, 2023

To close #7 #9 and add make task for Bakerloo network. This PR contains:

  • the removal of the flag and system environment variable of symbols
  • a build task in Makefile to make simulator service and its plugin for Bakerloo network.

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen changed the title improvement, deprecate the symbols flag & make for bakerloo net. improvement, deprecate the symbols flag & make binaires for Bakerloo testnet. Dec 6, 2023
@Jason-Zhangxin-Chen Jason-Zhangxin-Chen changed the title improvement, deprecate the symbols flag & make binaires for Bakerloo testnet. improvement, deprecate the symbols flag & make binaries for Bakerloo testnet. Dec 6, 2023
Copy link

@lorenzo-dev1 lorenzo-dev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen merged commit 1f70853 into master Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration options - should SYMBOLS be deprecated?
2 participants