Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "newTabPosition" API #22

Closed
Keith94 opened this issue Apr 5, 2018 · 5 comments
Closed

Add support for "newTabPosition" API #22

Keith94 opened this issue Apr 5, 2018 · 5 comments

Comments

@Keith94
Copy link

Keith94 commented Apr 5, 2018

https://bugzilla.mozilla.org/show_bug.cgi?id=1344749 was fixed today; I'm wondering if this add-on should use the new API to control new tabs position.

This patch implements the preference "browser.tabs.insertAfterCurrent" which,
when set to true, will cause all tabs (related and unrelated) to be opened next
to the current tab.

It also implements the browserSettings API "newTabPosition", which allows
extensions to control both "browser.tabs.insertRelatedAfterCurrent", and
"browser.tabs.insertAfterCurrent" via values for "afterCurrent",
"relatedAfterCurrent" and "atEnd".

@autonome
Copy link
Owner

autonome commented Apr 5, 2018 via email

@peteruithoven
Copy link

Looks like you did in the following commit?
83ad05b

And this it seems to work great in Firefox nightly 62, tabs are opened directly after the current instead of first being opened at the end and then moved.

@autonome
Copy link
Owner

Yes, fixed in latest release, for Firefox 61 and future!

@mems
Copy link

mems commented May 10, 2018

Does that means the only purpose of Always-Right will be to activate this native feature?

@Keith94
Copy link
Author

Keith94 commented May 11, 2018

@mems Yes. For more info see ghacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants