Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed small typo #53

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Fixed small typo #53

merged 1 commit into from
Aug 9, 2018

Conversation

roohat
Copy link
Contributor

@roohat roohat commented Aug 8, 2018

Fixed small typo

It's not that much of an issue but this could of easily prevented by having some Git typo hook to decline push/merge requests with typo in it. (e.g., https://github.com/intgr/topy)

It's not that much of an issue but this could of easily prevented by having some Git typo hook to decline push/merge requests with typo in it. (e.g., https://github.com/intgr/topy)
@coveralls
Copy link

coveralls commented Aug 8, 2018

Pull Request Test Coverage Report for Build 150

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 89.196%

Files with Coverage Reduction New Missed Lines %
talos/metrics/performance.py 3 87.84%
Totals Coverage Status
Change from base Build 148: 0.0%
Covered Lines: 710
Relevant Lines: 796

💛 - Coveralls

@roohat
Copy link
Contributor Author

roohat commented Aug 8, 2018

BTW, since talos uses Travis CI for CI there is way to add spelling integration as Travis addon. For integrate instructions: https://blog.eleven-labs.com/en/how-to-check-the-spelling-of-your-docs-from-travis-ci/

@roohat roohat closed this Aug 8, 2018
@roohat
Copy link
Contributor Author

roohat commented Aug 8, 2018

I should add a CI integration to myself. Accidentally closed the merge request 😅

@roohat roohat reopened this Aug 8, 2018
@matthewcarbone
Copy link
Collaborator

Hah! Thank you for catching this. I see no reason why we shouldn't merge this obviously, but I always wait for @mikkokotila's approval.

Wonder if it'll pass Travis...

@mikkokotila
Copy link
Contributor

Very good idea on adding the spelling hook for Travis! :) Will merge this now, but if you want to make a new one with the spelling hook, that will be great :)

@mikkokotila mikkokotila merged commit 717aa67 into autonomio:dev Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants