Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily dev #63

Closed
wants to merge 3 commits into from
Closed

Daily dev #63

wants to merge 3 commits into from

Conversation

mikkokotila
Copy link
Contributor

- this fixes the issue where using a custom metric does not behave as expected with peak epoch
- the WIKI needs to updated related with custom metrics (the word 'acc') needs to be in a metric always
Added descriptions to functions that did not have any (some may still remain).
@pep8speaks
Copy link

pep8speaks commented Aug 20, 2018

Hello @mikkokotila! Thanks for updating the PR.

Line 83:80: E501 line too long (86 > 79 characters)

Line 26:5: E741 ambiguous variable name 'l'
Line 57:13: E741 ambiguous variable name 'l'
Line 71:13: E741 ambiguous variable name 'l'
Line 111:80: E501 line too long (94 > 79 characters)
Line 117:80: E501 line too long (94 > 79 characters)
Line 141:13: E741 ambiguous variable name 'l'
Line 160:13: E741 ambiguous variable name 'l'
Line 176:9: E741 ambiguous variable name 'l'

Comment last updated on August 20, 2018 at 14:58 Hours UTC

@matthewcarbone
Copy link
Collaborator

matthewcarbone commented Aug 20, 2018

@mikkokotila regarding

the WIKI needs to updated related with custom metrics (the word 'acc') needs to be in a metric always

This would pose an issue if the user wanted to use the F1 score though, right?

Also side question: what is the daily-dev branch? 😄

@coveralls
Copy link

coveralls commented Aug 20, 2018

Pull Request Test Coverage Report for Build 161

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 88.962%

Files with Coverage Reduction New Missed Lines %
talos/metrics/performance.py 3 83.78%
Totals Coverage Status
Change from base Build 156: -0.2%
Covered Lines: 677
Relevant Lines: 761

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants