Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merging dev to daily-dev #77

Merged
merged 10 commits into from
Aug 25, 2018
Merged

merging dev to daily-dev #77

merged 10 commits into from
Aug 25, 2018

Conversation

mikkokotila
Copy link
Contributor

No description provided.

ackRow and others added 9 commits July 30, 2018 02:13
@ackRow
Functional Model Support v2
026a5a5 
Substitute `model.predict_classes`  (only available for Sequential Model) using `numpy.argmax` with `axis=-1` to match predict_classes shape.
@guilhermesilveira
fixing the notebook URI
7540674
@mikkokotila
Merge pull request #58 from guilhermesilveira/patch-1
9188981 
fixing the notebook URI
@ackRow
Merge pull request #1 from autonomio/dev
6a6aab8 
Syncing with original repo
Experimental Support for Functional Model
c7519c7 
Using a predict_classes function similar to Sequential Model for Functional Model

To use this experimental function add experimental_functional_support=True to the Scan() parameters

Adding a Jupyter Notebook example
@mikkokotila
Merge pull request #70 from ackRow/dev
d9b2c0b 
Adding Experimental Support for Functional Model
@mikkokotila
Merge pull request #71 from autonomio/daily-dev
b07cd68 
fixes #62 and adds several missing docstrings
Fixed the PEP8 issues
f0a1fbd
@mikkokotila
Merge pull request #75 from bluerocly/develop
1bfc720 
Issue with fn and fp values
@pep8speaks
Copy link

pep8speaks commented Aug 24, 2018 •
edited

Hello @mikkokotila! Thanks for updating the PR.

Line 6:69: W291 trailing whitespace
Line 37:80: E501 line too long (105 > 79 characters)
Line 39:1: W293 blank line contains whitespace
Line 45:1: W293 blank line contains whitespace
Line 45:1: W391 blank line at end of file

Line 14:80: E501 line too long (96 > 79 characters)
Line 14:93: E231 missing whitespace after ','

Line 20:80: E501 line too long (88 > 79 characters)
Line 22:80: E501 line too long (87 > 79 characters)

Comment last updated on August 25, 2018 at 16:22 Hours UTC

@coveralls
Copy link

coveralls commented Aug 24, 2018 •
edited

Pull Request Test Coverage Report for Build 177

  • 8 of 16 (50.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 87.995%
Changes Missing Coverage Covered Lines Changed/Added Lines %
talos/metrics/score_model.py 4 12 33.33%
Totals Coverage Status
Change from base Build 166: -0.8%
Covered Lines: 711
Relevant Lines: 808
💛 - Coveralls

@mikkokotila
fixed a bug in names
2539de5 
- there was a bug in the metric_names
- and another bug in reductions
- this also revealed the issue with the test script related with reduction tests (the threshold should be 0.01 or similar low to make sure that the reduction runs)
@mikkokotila mikkokotila merged commit 8f51e7d into daily-dev Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikkokotila @pep8speaks @coveralls @ackRow @guilhermesilveira