Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel processing #23

Merged
merged 2 commits into from Feb 21, 2020
Merged

Add parallel processing #23

merged 2 commits into from Feb 21, 2020

Conversation

mikkokotila
Copy link
Contributor

@mikkokotila mikkokotila commented Feb 21, 2020

You want to make a PR to Wrangle

Thanks so much :) First, please take a moment to carefully check through
the below items:

Sanity

  • I'm aware of the implications of the proposed changes
  • Code is PEP8
  • I'm making the PR to master

Docs

  • Docs are updated
  • Docs version is correct (index.html and _coverpage.md)

Tests

  • Changes have gone through actual use testing
  • All local tests have passed (run ./test.sh in /talos)
  • Tests have been updated to reflect the changes

@pep8speaks
Copy link

Hello @mikkokotila! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2:1: W293 blank line contains whitespace
Line 4:1: W293 blank line contains whitespace
Line 9:1: W293 blank line contains whitespace
Line 13:1: W293 blank line contains whitespace
Line 19:1: W293 blank line contains whitespace

@mikkokotila mikkokotila merged commit 4d62d29 into master Feb 21, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 112

  • 2 of 11 (18.18%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 50.874%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wrangle/df/df_parallelize_process.py 1 10 10.0%
Totals Coverage Status
Change from base Build 107: -0.3%
Covered Lines: 611
Relevant Lines: 1201

💛 - Coveralls

@mikkokotila mikkokotila deleted the add_parallel_processing branch February 21, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants