Support a primary entry point for bundles. #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonomousapps
commented
May 9, 2022
| dependencyAnalysis { | ||
| dependencies { | ||
| bundle('facade') { | ||
| primary(':entry-point') |
There was a problem hiding this comment.
This is what the new API looks like in practice. Note that I haven't added an override to the bundle() function, primarily due to limitations in Gradle that make it annoying to create domain objects with custom constructors.
autonomousapps
commented
May 9, 2022
| * | | ||
| * C -> used as API, part of bundle with B. Should not be declared! | ||
| */ | ||
| internal class Bundles(private val dependencyUsages: Map<Coordinates, Set<Usage>>) { |
There was a problem hiding this comment.
Moved from elsewhere for easier testing.
autonomousapps
commented
May 9, 2022
| val bundles = Bundles(dependencyUsages) | ||
|
|
||
| // Handle bundles with primary entry points | ||
| bundleRules.primaries.forEach { (name, primaryId) -> |
There was a problem hiding this comment.
Some ugly duplication here, but it works ™️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #662.