-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive #1180
Comments
This looks to me like you run into the special treatment of If something is already However, if you want to look at There is a proposal to make this configurable (#900). Meaning, the plugin could introduce an option do disable this special treatment of Note: This has nothing to do with JPMS. It's the same behavior for any Jar. I think this can be closed in favor of #900. |
Hmm... except annotations are weird, and a bit obnoxious, because even if an annotation were to describe itself as |
not certain why, maybe a different inter-related bug, but now I'm getting a build failure on buildhealth again
which makes no sense because I told it to ignore it dependencyAnalysis {
issues {
all {
onAny {
severity("fail")
}
onUnusedDependencies {
exclude(libs.junit.parameters)
exclude(libs.assertj)
exclude(libs.spring.test)
exclude(libs.spring.boot.test.autoconfigure)
exclude(libs.spring.boot.test.core)
}
}
// false positive
project(":jpa") {
sourceSet("test") {
onUnusedDependencies {
exclude(libs.java.tools)
}
}
}
} |
Could you test this on the latest version? There have been some fixes that might be relevant. |
Build scan link
https://scans.gradle.com/s/5ox43obbapdui
Plugin version
1.31.0
Gradle version
(Optional)
reason
output for bugs relating to incorrect adviceDescribe the bug
So even the reason here implies that it knows I need
testImplementation
but then I get this
To Reproduce
sorry, I haven't created a minimal reproducer, I actually can't imagine with this being the only case I see right now what would cause it. Here's the pointers to the code, but to use the repo you'll have to follow the instructions to set up github packages.
build scan was taken with this commented out https://github.com/xenoterracide/spring-app-commons/blob/ea49791ed7597642e7aca910a9a0203c8b6fb806/build.gradle.kts#L35-L41
this is where the import for the module being complained about is used
https://github.com/xenoterracide/spring-app-commons/blob/ea49791ed7597642e7aca910a9a0203c8b6fb806/module/jpa/src/test/java/com/xenoterracide/jpa/FooAggregate.java#L6
and obviously this is needed at runtime
https://github.com/xenoterracide/spring-app-commons/blob/ea49791ed7597642e7aca910a9a0203c8b6fb806/module/jpa/src/test/java/com/xenoterracide/jpa/FooAggregate.java#L56
Expected behavior
module is not unused.
Additional context
I wonder if it has anything to do with usage of JPMS, or if it has something to do with this using a "3rd party" repo.
The text was updated successfully, but these errors were encountered: