Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used transitive dependencies advice for test dependencies suggests wrong configuration #424

Closed
gabrielittner opened this issue Jun 20, 2021 · 1 comment · Fixed by #428
Closed
Labels
bug Something isn't working
Milestone

Comments

@gabrielittner
Copy link
Contributor

Build scan link

transitive-test.zip

Plugin version

0.74.0

Gradle version

7.0

(Optional) Android Gradle Plugin (AGP) version

4.2.1

Describe the bug

I'm depending on io.kotest:kotest-assertions-core-jvm in testImplementation but only use things from the transitive io.kotest:kotest-assertions-shared-jvm dependency. I correctly get the advice to remove the former, but the suggestion to add the latter directly tells me to add it using implementation instead of testImplementation.

Advice for project :settings
Unused dependencies which should be removed:
- testImplementation("io.kotest:kotest-assertions-core-jvm:4.6.0")

Transitively used dependencies that should be declared directly as indicated:
- implementation("io.kotest:kotest-assertions-shared-jvm:4.6.0")

To Reproduce
Steps to reproduce the behavior:

See above or sample project.

Expected behavior

The advice should be

Advice for project :settings
Unused dependencies which should be removed:
- testImplementation("io.kotest:kotest-assertions-core-jvm:4.6.0")

Transitively used dependencies that should be declared directly as indicated:
- testImplementation("io.kotest:kotest-assertions-shared-jvm:4.6.0")
@autonomousapps
Copy link
Owner

The fix for this will be published with the next release. You can already verify by using the latest snapshot (once it gets published).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants