Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Add price charts to Converter and Auction screens #415

Closed
wants to merge 4 commits into from
Closed

Conversation

pablen
Copy link
Contributor

@pablen pablen commented Nov 21, 2018

Closes #414

@pablen pablen self-assigned this Nov 21, 2018
@gabmontes
Copy link
Member

@pablen the charts look very nice! Some comments to discuss:

  • When the window is reduced to its minimum size, the auction chart falls of the screen and the converter chart pushes the "Convert" button off the screen too. We should consider a different placement or min window size?

  • The default chart timeframe should be 1 day to show more useful data to the users.

  • The data is retrieved every time the tab changes and that should be cached (not necessarily persisted).

  • Is the data updated in realtime? It looks like it is not.

  • The build is failing. Should investigate the reason before approving/merging.

Pablo Enrici added 2 commits November 22, 2018 12:26
Tests rendering components that include Victory charts require unmounting the components after the test.
ES6 code in node_modules would break the build.
@pablen
Copy link
Contributor Author

pablen commented Nov 27, 2018

Closing for now as we'll move this new feature into the next major release.

@pablen pablen closed this Nov 27, 2018
@pablen pablen deleted the charts branch November 29, 2018 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants