Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings seem different than described in paper #1

Closed
ch-sa opened this issue Nov 21, 2021 · 1 comment · Fixed by #2
Closed

Keybindings seem different than described in paper #1

ch-sa opened this issue Nov 21, 2021 · 1 comment · Fixed by #2

Comments

@ch-sa
Copy link
Contributor

ch-sa commented Nov 21, 2021

Hi @yiyiliao,

great that you published and open sourced your annotation tool here. I was just a little confused about the key bindings, as they seem differently configured than described in the paper.

grafik

The paper says the E key switches to scaling, while the R key enables rotation mode. Yet in the software it seems to be implemented vice versa.

Also it was interesting seeing your approach as I implemented a similar software last year for labeling 3D bounding boxes in point clouds called labelCloud. We also presented and published it in CAD21, maybe the corresponding publication is also of interest for you.

UPDATE:

  • I added a pull request that fixes the issue. It should be ready to merge.

Best regards,

Christoph

ch-sa added a commit to ch-sa/kitti360LabelTool that referenced this issue Nov 21, 2021
 - Scaling and rotation were swapped before

Closes: autonomousvision#1
ch-sa added a commit to ch-sa/kitti360LabelTool that referenced this issue Nov 21, 2021
 - Scaling and rotation were swapped before

Closes: autonomousvision#1
@yiyiliao
Copy link
Contributor

Hi @ch-sa, thanks a lot for pointing out the issue and for fixing it!

Thank you for your pointer to labelCloud as well. This looks quite relevant indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants