Fix the secondary runtime metadata

[liuchengxu]

polkadot.js is broken due to the metadata RPC call panics.

FATAL: Unable to initialize the API: -32603: Unknown error occurred: Client error: Execution failed: Runtime panicked: All path segments should be valid Rust identifiers: InvalidIdentifier { segment: 1 }

It turns out r# is unsupported by scale-info.

[nazar-pc]

Why idea why does scale-info care about that module in the first place?

[liuchengxu]

scale-info defines a Path to represent the location of a type definition which is constructed using the segments splitted from the module path using :: https://github.com/paritytech/scale-info/blob/0c4ff0b7cd135375c3b4991e6d9fd7105ca9b083/src/ty/path.rs#L100, I guess in our case some segment will contain # which is considered to be an invalid Rust identifier https://github.com/paritytech/scale-info/blob/0c4ff0b7cd135375c3b4991e6d9fd7105ca9b083/src/utils.rs#L16.

[nazar-pc]

I used r#impl in both runtimes. Does this mean we need to fix both?

[nazar-pc]

Also worth reporting this upstream, can you create an issue, please?

[liuchengxu]

I used r#impl in both runtimes. Does this mean we need to fix both?

Yes, missed the one in the test runtime, will update.

Also worth reporting this upstream, can you create an issue, please?

Sure, will do.