update ContainerPilot to 3.0.0-RC1 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
CPv3
branch
2 times, most recently
from
768e32d
to
50d82db
Compare
tgross
changed the title
|
Any objections to merging this? |
geek
approved these changes
Jun 1, 2017
misterbisson
reviewed
Jun 1, 2017
| EXPOSE 80 | ||
| CMD ["/bin/containerpilot", "nginx"] | ||
| CMD ["/bin/containerpilot"] |
There was a problem hiding this comment.
This is another case where the CMD is being truncated. Can you say more about the changed philosophy behind the change?
There was a problem hiding this comment.
It's a requirement of multi-process support, as described in the RFD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ContainerPilot to the 3.0.0-RC1 release candidate. There's no Jenkins job for this blueprint but I've tested it out to my satisfaction locally.
cc @misterbisson @cheapRoc @geek