Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Overridden "NAME" in Office 2016 Munki Recipes? #15

Closed
foigus opened this issue May 14, 2015 · 4 comments
Closed

Retain Overridden "NAME" in Office 2016 Munki Recipes? #15

foigus opened this issue May 14, 2015 · 4 comments
Assignees
Labels

Comments

@foigus
Copy link
Contributor

foigus commented May 14, 2015

If I create an override for an Office 2016 Munki recipe (say "MSExcel2016.munki.recipe") and set:

  • The "NAME" to "Excel2016_update"
  • Set the "display_name" to "Microsoft Excel Display Name"

when I run the overridden recipe I get a pkginfo file:

  • Named "Excel_2016_Installer-15.9.plist"
  • The "name" set to "Excel_2016_Installer"
  • The "display_name" set to "Microsoft Excel Display Name" (e.g. it was successfully overridden, testing to make sure the override is being evaluated)

My expectation is that I'd get a pkginfo file:

  • Named "Excel2016_update-15.9.plist"
  • The "name" set to "Excel2016_update"

The Office 2011 recipe follows the latter example above--if I override the "name" of "MSOffice2011Updates.munki.recipe" and set it to "foo", I get a pkginfo file:

  • Named "foo-14.5.0.plist"
  • The "name" set to "foo"

My override file is below:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>Identifier</key>
    <string>local.munki.MSExcel2016</string>
    <key>Input</key>
    <dict>
        <key>CULTURE_CODE</key>
        <string>0409</string>
        <key>MUNKI_REPO_SUBDIR</key>
        <string>apps</string>
        <key>NAME</key>
        <string>Excel2016_update</string>
        <key>VERSION</key>
        <string>latest</string>
        <key>display_name</key>
        <string>Microsoft Excel Display Name</string>
        <key>pkginfo</key>
        <dict>
            <key>blocking_applications</key>
            <array>
                <string>Microsoft Excel</string>
                <string>Microsoft Error Reporting</string>
                <string>Microsoft Auto Update</string>
            </array>
            <key>catalogs</key>
            <array>
                <string>testing</string>
            </array>
            <key>category</key>
            <string>Productivity</string>
            <key>developer</key>
            <string>Microsoft</string>
            <key>display_name</key>
            <string>%display_name%</string>
            <key>installs</key>
            <array>
                <dict>
                    <key>CFBundleIdentifier</key>
                    <string>com.microsoft.Excel</string>
                    <key>CFBundleName</key>
                    <string>Excel</string>
                    <key>path</key>
                    <string>/Applications/Microsoft Excel.app</string>
                </dict>
            </array>
            <key>minimum_os_version</key>
            <string>10.10.0</string>
        </dict>
    </dict>
    <key>ParentRecipe</key>
    <string>com.github.arubdesu.munki.MSExcel2016</string>
</dict>
</plist>
@arubdesu
Copy link
Member

Yup, my oversight to have dropped that key from the input stanza, will fix

@arubdesu arubdesu self-assigned this May 14, 2015
@arubdesu arubdesu added the bug label May 14, 2015
@arubdesu arubdesu mentioned this issue May 18, 2015
@foigus
Copy link
Contributor Author

foigus commented May 18, 2015

No luck yet. My override file (below) results in a pkginfo of "Excel_2016_Installer-15.10.plist" that has a "name" key set to "Excel_2016_Installer".

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>Identifier</key>
    <string>local.munki.MSExcel2016</string>
    <key>Input</key>
    <dict>
        <key>CULTURE_CODE</key>
        <string>0409</string>
        <key>MUNKI_REPO_SUBDIR</key>
        <string>apps/microsoft</string>
        <key>NAME</key>
        <string>Excel2016</string>
        <key>VERSION</key>
        <string>latest</string>
        <key>display_name</key>
        <string>Excel 2016</string>
        <key>pkginfo</key>
        <dict>
            <key>blocking_applications</key>
            <array>
                <string>Microsoft Excel</string>
                <string>Microsoft Error Reporting</string>
                <string>Microsoft Auto Update</string>
            </array>
            <key>catalogs</key>
            <array>
                <string>development-microsoft-Excel2016</string>
            </array>
            <key>category</key>
            <string>Productivity</string>
            <key>developer</key>
            <string>Microsoft</string>
            <key>display_name</key>
            <string>%display_name%</string>
            <key>installs</key>
            <array>
                <dict>
                    <key>CFBundleIdentifier</key>
                    <string>com.microsoft.Excel</string>
                    <key>CFBundleName</key>
                    <string>Excel</string>
                    <key>path</key>
                    <string>/Applications/Microsoft Excel.app</string>
                </dict>
            </array>
            <key>minimum_os_version</key>
            <string>10.10.0</string>
            <key>unattended_install</key>
            <true/>
        </dict>
    </dict>
    <key>ParentRecipe</key>
    <string>com.github.arubdesu.munki.MSExcel2016</string>
</dict>
</plist>

@arubdesu
Copy link
Member

For future generations, I've re-purposed the update-naming specific variable from Office2011 to fulfill this purpose. Example override: https://gist.github.com/arubdesu/dc0990e57e65ee2aaa6d
Thanks!

@erikng
Copy link

erikng commented May 28, 2015

Why can't you follow %NAME% like most others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants