Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office 2016 Recipes - missing munki_update_name argument #20

Closed
jimrt opened this issue Jun 2, 2015 · 3 comments
Closed

Office 2016 Recipes - missing munki_update_name argument #20

jimrt opened this issue Jun 2, 2015 · 3 comments

Comments

@jimrt
Copy link

jimrt commented Jun 2, 2015

This is a relatively minor issue. I noticed that the NAME value I specified in the overrides for the MSExcel2016.munki, MSOneNote.munki, MSPowerPoint2016.munki and MSWord2016.munki recipes was being ignored.

I had to add munki_update_name to the MSOffice2016URLandUpdateInfoProvider Arguments list in the respective pkg recipes for these 4 products.

example change for the MSExcel2016 pkg recipe

--- MSExcel2016.pkg.recipe  2015-06-02 13:36:13.000000000 -0400
+++ MSExcel2016.pkg.recipe  2015-06-02 13:11:45.000000000 -0400
@@ -29,6 +29,8 @@
             <dict>
                 <key>product</key>
                 <string>Excel</string>
+                <key>munki_update_name</key>
+                <string>%NAME%</string>
             </dict>
         </dict>
         <dict>
@arubdesu
Copy link
Member

arubdesu commented Jun 3, 2015

Huh, that looks really good, thanks for bringing it to my attention. Mind baking that into a PR? I'm sure my example override in #15 is less discoverable than that would be. 🙇

@jimrt
Copy link
Author

jimrt commented Jun 3, 2015

PR submitted. This is my first Pull Request on GitHub, so I hope that I did it correctly.

@arubdesu
Copy link
Member

arubdesu commented Jul 1, 2015

You did everything just fine, but I balked at the idea of, by setting the key to the recipe's pre-existing Name value, breaking existing munki pkg relationships. Pardon that I took your fix and put a spin on it, thanks for your patience.

@arubdesu arubdesu closed this as completed Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants