Fixed SparkleUpdateInfoProvider ignoring appcast_request_headers #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It would appear that the recent change from using urllib to curl introduced a subtle bug wherein the SparkleUpdateInfoProvider processor was effectively ignoring `appcast_request_headers`. * The fix: within the `get_feed_data()` function, the line calling `self.fetch_content()` was giving `appcast_query_pairs` as the second argument (which `get_feed_data()` took as its `headers=` argument). Since `appcast_query_pairs` are url encoded in the code block immediately before this call, all that’s missing was to remove the extraneous argument with a corrected `headers=` one.
|
Bump. (This affects, at least, com.github.timsutton.munki.HopperDisassembler3 and com.github.keeleysam.recipes.Twocanoes.WinclonePro4.munki). |
|
Thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced a subtle bug wherein the SparkleUpdateInfoProvider processor
was effectively ignoring
appcast_request_headers.get_feed_data()function, the line callingself.fetch_content()was givingappcast_query_pairsas the secondargument (which
get_feed_data()took as itsheaders=argument).Since
appcast_query_pairsare url encoded in the code blockimmediately before this call, all that’s missing was to remove the
extraneous argument with a corrected
headers=one.