Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github action unittests tests.yaml #897

Merged
merged 4 commits into from Oct 9, 2023
Merged

Conversation

jgstew
Copy link
Contributor

@jgstew jgstew commented Sep 26, 2023

fix autopkg tests by having it generate recipe map.

fix autopkg tests by having it generate recipe map.
fix test due to missing folder for recipe map
@jgstew jgstew changed the title Update tests.yaml fix github action unittests tests.yaml Sep 26, 2023
fix for macos missing dir
fix github token
@jgstew
Copy link
Contributor Author

jgstew commented Sep 26, 2023

I'm not sure why the windows tests are still failing, it might be due to problems setting the github token and it not working correctly?

It is specifically SignToolVerifier that is failing on windows, but the rest of the tests are working now.

@jgstew
Copy link
Contributor Author

jgstew commented Sep 26, 2023

Note: ${{ secrets.GITHUB_TOKEN }} is how github actions provide the actual token inline. That shouldn't change, but where it is written to should based upon the new default path for the github token.

@jgstew
Copy link
Contributor Author

jgstew commented Sep 26, 2023

The github token doesn't seem to be read correctly in the unit tests, and the default value doesn't seem to get written into the preferences like I expect:

AutoPkg_GH_Token

@nmcspadden nmcspadden merged commit d72a5a5 into autopkg:dev Oct 9, 2023
2 of 3 checks passed
@jgstew jgstew deleted the patch-11 branch October 11, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants