Overhauling HPPrinterDrivers #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to some changes on HP's side, the HPPrinterDrivers recipe is not functioning. I have made some changes in order to fix those errors and provide greater flexibility in the recipe. ### HPSoftwareInfoProvider.py * Added additional imports * Removed Python 2 workaround * Modified HP_BASE_URL to also have a key for the query type * Added optional query * Fixed references to case-sensitive environment variables * Added new HP_QUERY_TYPE environment variable * Modified "OS" to be `operating_system` to prevent conflicts with `os` built-in. * Changed "product_number" to "HP_QUERY" as it's ProductNumber sometimes and ModelName otherwise * Used the packaging versioner to parse the version strings and figure out which is higher. It is *not* always the first one in the new schema. * Verified if the discovered url begins with `ftp` and modify it to use `https` since the HP FTP server rejects FTP requests now. Even the HP Easy Admin client tries HTTPS first. ### HPPrinterDrivers.download.recipe * Modified to use the above changes.
|
Oh my! I've been wanting to figure out a way to fix my HP Print Driver override for so long.... It "worked" (I guess until recently), but 98 times out of 100, it would fail at the end of the download. When I looked at it forever ago, it was (vaguely something along the lines of) an issue with curl and FTP, where curl just didn't receive the proper closing it expected on the file and thought it was corrupted, but if you renamed the temp file that curl downloads, e.g. I've just been ignoring the failure for years as it would randomly work, while hoping HP would eventually stop using FTP as the service to distribute these drivers. And I didn't notice the error had changed from what it used to be. I went to look into this again and find this PR, which is super exciting! (As much as an AutoPkg recipe, albeit working, can be.) I've tested these changes and I can confirm they work as is, but it will not work if you try to use the original method and value, e.g. using <key>HP_QUERY_TYPE</key>
<string>ProductNumber</string>
<key>HP_QUERY</key>
<string>E6B70A</string>Due to Which results in the variable Traceback (most recent call last):
File "/Library/AutoPkg/autopkglib/__init__.py", line 840, in process
self.env = processor.process()
File "/Library/AutoPkg/autopkglib/__init__.py", line 626, in process
self.main()
File "~/Library/AutoPkg/RecipeRepos/com.github.autopkg.n8felton-recipes/SharedProcessors/HPSoftwareInfoProvider.py", line 144, in main
parsed_url = urlparse(recent_software["FtpURL"])
UnboundLocalError: local variable 'recent_software' referenced before assignment
File "/Library/AutoPkg/autopkglib/__init__.py", line 840, in process
self.env = processor.process()
local variable 'recent_software' referenced before assignmentThis may want to be accounted for in the PR, but otherwise, I got an updated .pkg using the default values, with a newer .pkg version with all (actually more) of the same printer models PPDs files. Great work @primalcurve, I really appreciate the contribution. |
Closed
|
Great work on this! Sorry for my extended delayed response to this. I added a few extra bits to what you had. Give everything look over and if you're good with them, I'll finish up this PR. Thanks again! |
|
@n8felton Works great for me still. (I cleaned up some of the unnecessary output.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some changes on HP's side, the HPPrinterDrivers recipe is not functioning. I have made some changes in order to fix those errors and provide greater flexibility in the recipe.
HPSoftwareInfoProvider.py
operating_systemto prevent conflicts withosbuilt-in.ftpand modify it to usehttpssince the HP FTP server rejects FTP requests now. Even the HP Easy Admin client tries HTTPS first.HPPrinterDrivers.download.recipe
Output of
autopkg run -vvvv