Skip to content

Commit

Permalink
feat: Add harness support for units specified in ASC-51
Browse files Browse the repository at this point in the history
ASC-51 added formal support for concentration units (amount, mass,
volume) into the Autoprotocol spec.

This adds support for these units into the harness, keeping to a similar
namespace.

Note that support for `concentration(mass)`, `concentration(molar)`
should be deprecated in some future major version bump.
  • Loading branch information
yangchoo committed Sep 11, 2020
1 parent 63a64e1 commit a9a38a6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
10 changes: 7 additions & 3 deletions autoprotocol/harness.py
Expand Up @@ -220,10 +220,14 @@ def convert_param(protocol, val, type_desc):
f"improperly formatted."
)
elif type in [
"volume",
"time",
"length",
"amount_concentration",
"frequency",
"length",
"mass_concentration",
"time",
"volume",
"volume_concentration",
# TODO: Deprecate the following two types in next major release
"concentration(mass)",
"concentration(molar)",
]:
Expand Down
1 change: 1 addition & 0 deletions docs/changelog.rst
Expand Up @@ -2,6 +2,7 @@
Changelog
=========

* :feature:`265` Add support for mass_concentration, amount_concentration and volume_concentration, as specified in ASC-51
* :support:`267` Pin black version to reduce CI/local inconsistencies. Pin to 20.8b1

* :release:`7.1.1 <2020-07-21>`
Expand Down

0 comments on commit a9a38a6

Please sign in to comment.