Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use black as autoformatter #247

Merged
merged 1 commit into from
May 22, 2020
Merged

build: Use black as autoformatter #247

merged 1 commit into from
May 22, 2020

Conversation

yangchoo
Copy link
Contributor

Add black as a dependency to pre-commit so that it can be run locally
and as part of CI infrastructure.

This also checks in the auto-formatting changes from black.

Using default black configuration, e.g. max line-length is 88

@yangchoo
Copy link
Contributor Author

yangchoo commented May 22, 2020

From a skim, most of the changes are related to

  • consistency on quotes (generally ' -> ")
  • adding trailing commas
  • indentations
  • extraneous parens removal

Add black as a dependency to pre-commit so that it can be run locally
and as part of CI infrastructure.

This also checks in the auto-formatting changes from black.

Using default black configuration, e.g. max line-length is 88
Copy link
Member

@rhysormond rhysormond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! we've been meaning to adopt this for a while. this seems like an improvement across the board!

@yangchoo yangchoo merged commit 2ced9f9 into master May 22, 2020
@yangchoo yangchoo deleted the blacken-appy branch May 22, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants