Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make updates to align with autoprotocol-service #385

Merged
merged 10 commits into from Feb 24, 2023

Conversation

EribertoLopez
Copy link
Contributor

@EribertoLopez EribertoLopez commented Feb 22, 2023

Continuing updates for dataclasses and further typing...

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #385 (78f38d6) into master (59f6dae) will increase coverage by 0.41%.
The diff coverage is 96.53%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   84.21%   84.62%   +0.41%     
==========================================
  Files          22       23       +1     
  Lines        4404     4541     +137     
==========================================
+ Hits         3709     3843     +134     
- Misses        695      698       +3     
Impacted Files Coverage Δ
autoprotocol/version.py 0.00% <0.00%> (ø)
autoprotocol/unit.py 88.54% <84.61%> (-0.97%) ⬇️
autoprotocol/protocol.py 79.32% <95.65%> (+0.06%) ⬆️
autoprotocol/types/protocol.py 98.13% <95.78%> (-1.04%) ⬇️
autoprotocol/builders.py 85.73% <97.82%> (-0.35%) ⬇️
autoprotocol/types/builders.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@joshhacksthings joshhacksthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just had a comment. also update changelog!

autoprotocol/unit.py Outdated Show resolved Hide resolved
valtriadi
valtriadi previously approved these changes Feb 22, 2023
Copy link
Collaborator

@valtriadi valtriadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
(just tiny nitty thought below)

autoprotocol/builders.py Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
@EribertoLopez EribertoLopez force-pushed the STDV-2057-updates-for-dataclasses branch from 335c285 to 75c0ade Compare February 24, 2023 17:34
Copy link
Collaborator

@valtriadi valtriadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@EribertoLopez EribertoLopez merged commit 2e554e7 into master Feb 24, 2023
@EribertoLopez EribertoLopez deleted the STDV-2057-updates-for-dataclasses branch February 24, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants