PP-12831 #395
PP-12831 #395
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #395 +/- ##
==========================================
- Coverage 84.64% 84.50% -0.14%
==========================================
Files 24 24
Lines 4551 4551
==========================================
- Hits 3852 3846 -6
- Misses 699 705 +6
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -7896,7 +7896,7 @@ def informatics_helper(informatics, dest, multi_src): | |||
|
|
|||
| # apply tip types to transfer methods | |||
| for vol, met in zip(volume, method): | |||
| if not met.tip_type: | |||
| if met._has_calibration() and not met.tip_type: | |||
There was a problem hiding this comment.
Curious, prior to this change, was a runtime error being raised resulting in the tip type assignment?
There was a problem hiding this comment.
Yep! Removing this is what introduced us setting filtered1000s in mode_params.
There was a problem hiding this comment.
The reason I ask is because there are tests in Txappy that depend on a runtime error being triggered so if we gate this with the `_has_calibration() method we may break the tests in Txappy. Here are the lines to confirm and update if this is True: https://github.com/strateos/txappy/blob/751890f8a6353d385bc35177490d46cd4a1b7372/test/liquid_handle_test.py#L102
https://github.com/strateos/txappy/blob/751890f8a6353d385bc35177490d46cd4a1b7372/test/liquid_handle_test.py#L42
There was a problem hiding this comment.
Will address the txappy tests and update them in a different PR.
This PR updates protocol.py to not pass in mode params and tip type in the liquid handle transfer instruction.
Tested by generating a test run and you can see the last two liquid handle instructions dont have the mode params and tip type appended.