Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_web_socket on OSX by creating mock outside of assignment. #1049

Merged

Conversation

DocGarbanzo
Copy link
Contributor

It seems that creating the Mock outside of the assignment fixes the instabilities in pytest.

Copy link
Contributor

@Ezward Ezward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@DocGarbanzo DocGarbanzo merged commit 5e76b71 into autorope:main Oct 25, 2022
Mux199 added a commit to Mux199/donkeycar that referenced this pull request Oct 26, 2022
Try to fix test by creating mock outside of assignment. (autorope#1049)
@DocGarbanzo DocGarbanzo deleted the fix_osx_ci_error_in_test_web_socket branch November 29, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants