Add back support for tubhist #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tikurahul
reviewed
Nov 30, 2021
| path_list = tub_paths.split(",") | ||
| records = [record for path in path_list for record | ||
| in Tub(path, read_only=True)] | ||
| df = pd.DataFrame(records) |
There was a problem hiding this comment.
Pandas is a pretty heavy package to install on a SBC. If you can avoid it, that would be a lot nicer. We have been trying to avoid dependencies on it in the past.
There was a problem hiding this comment.
Good point, at least we can move the import into the function, one wouldn't run it on the RPi anyway as it directly prints into the screen.
DocGarbanzo
force-pushed
the
resurrect_tubhist
branch
from
28b2428
to
6f38b04
Compare
tikurahul
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
donkey tubhistcommand got lost when migrating to 4.x. We are bringing it back here.