Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem Description : Ruby test was not available on autotest. #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

anupkumk
Copy link

Fix : Added ruby test suits for autotest.
Signed-off By: Anup Kumar anupkumk@linux.vnet.ibm.com

Fix : Added ruby test suits to autotest.
Signed-off By: Anup Kumar <anupkumk@linux.vnet.ibm.com>
Trigger test run
"""
try:
os.environ["LTPBIN"] = "%s/shared" %(test_path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using os.path.join()

"""
try:
os.environ["LTPBIN"] = "%s/shared" %(test_path)
ret_val = subprocess.Popen(['./ruby.sh'], cwd="%s/ruby" %(test_path))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

if ret_val.returncode != 0:
self.nfail += 1

except error.CmdError, e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use proper variable name instead of e here and elsewhere

usage:
------
cd /opt/fiv/ltp/testcases/fivextra/ruby
./ruby.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to run from autotest path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants