virtual_disk: add new cases for starting guest with multiple driver attributes #5621
Conversation
|
|
@chunfuwen Hi, could you help to review this virtual disk PR? Thanks. |
| from provider.virtual_disk import disk_base | ||
|
|
||
|
|
||
| def prepare_guest(vm, vmxml, disk_obj, params): |
There was a problem hiding this comment.
prepare_guest mix adding second disk and update system disk together, it is hard for others to read. Better separate them into two method.
There was a problem hiding this comment.
I'm not sure how to split them. Because from the scenarios perspective I think it may be reasonable. Could you give me some detailed introduction if you find the better method. Thanks.
There was a problem hiding this comment.
Split the function to two functions to add new scenarios in the future easily.
| test.log.info("STEP3: login the guest and read/write.") | ||
| session = vm.wait_for_login() | ||
| if disk_type == "file": | ||
| session.cmd("mkfs.ext4 /dev/%s && mount /dev/%s /mnt" % (disk_dev, disk_dev)) |
There was a problem hiding this comment.
libvirt_disk.fill_null_in_vm() implements similar function
There was a problem hiding this comment.
In test case only file disk need to format the vdb disk but not for the block disk. If we use libvirt_disk.fill_null_in_vm(), both the file disk and block disk will format which is not our expected. So I think it's inappropriate to use this function.
|
|
||
| finally: | ||
| bkxml.sync() | ||
| libvirt.setup_or_cleanup_iscsi(is_setup=False) |
There was a problem hiding this comment.
Not all scenarios call libvirt.setup_or_cleanup_iscsi(is_setup=True) before , I assume
There was a problem hiding this comment.
Yes, only block disk test uses this function. I've updated now.
…ttributes These two cases are to match the cnv scenarios: VIRT-300872 and VIRT-300727. Signed-off-by: Meina Li <meili@redhat.com>
These two cases are to match the cnv scenarios: VIRT-300872 and VIRT-300727.