Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: Add more test cases for usb devices #646

Closed
wants to merge 3 commits into from
Closed

qemu: Add more test cases for usb devices #646

wants to merge 3 commits into from

Conversation

zhouqt
Copy link
Member

@zhouqt zhouqt commented Jul 17, 2013

No description provided.

@jzupka
Copy link
Contributor

jzupka commented Jul 22, 2013

I like this pull-request. Only some minor problems.

@zhouqt
Copy link
Member Author

zhouqt commented Jul 23, 2013

@jzupka Hi, new version sent.

@zhouqt
Copy link
Member Author

zhouqt commented Jul 23, 2013

@jzupka
I've marked this test as RHEL host only, so the software_manager module is unnecessary.
And for the sar package, I must keep this script work, without raising the TestNAError (It's really funny a script is written but can't be run).
BTW, all our internal hosts have this package installed.

If you don't like this solution, I can remove this separated patch from this pullreq, so that others can be merged.

@jzupka
Copy link
Contributor

jzupka commented Jul 23, 2013

@zhouqt If you really need force this pull request to upstream please remove first patch b8b1459 and please repair it in new version. I like the idea of patch. With software_manager it could be really nice solution and check find_command should be good.
If all yours computers have installed sar then it doesn't end with TestNAError.

I though something like this:

try:
   find_command(sar)
except ValueError:
   software_manager = SoftwareManager()
   if software_manager.install(usb_sar_pgk):
        logging.info("Packages %s installed successfuly", usb_sar_pgk)
    else:
        logging.error("Failed to install %s", usb_sar_pgk)

Signed-off-by: Qingtang Zhou <qzhou@redhat.com>
Signed-off-by: Qingtang Zhou <qzhou@redhat.com>
Signed-off-by: Qingtang Zhou <qzhou@redhat.com>
@zhouqt
Copy link
Member Author

zhouqt commented Jul 23, 2013

@jzupka removed.

@jzupka
Copy link
Contributor

jzupka commented Jul 23, 2013

Acked-by: @jzupka

@lmr
Copy link
Member

lmr commented Aug 7, 2013

Pushed to next, thanks guys!

@lmr lmr closed this Aug 7, 2013
@zhouqt zhouqt deleted the usb branch August 16, 2013 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants